Make MS2 codepaths supply fieldMap for Sort.getOrderByClause()#894
Merged
labkey-matthewb merged 2 commits intodevelopfrom Jun 11, 2025
Merged
Make MS2 codepaths supply fieldMap for Sort.getOrderByClause()#894labkey-matthewb merged 2 commits intodevelopfrom
labkey-matthewb merged 2 commits intodevelopfrom
Conversation
Contributor
|
@labkey-matthewb check out the changes I pushed to this and the platform FB. One MS2 usage was dead code. I hacked up the map for the other one. |
labkey-matthewb
commented
Jun 11, 2025
| FieldKey fk = FieldKey.fromParts(name); | ||
| BaseColumnInfo col = new BaseColumnInfo(fk, JdbcType.VARCHAR); | ||
| col.setSortFieldKeys(Collections.singletonList(fk)); | ||
| col.setAlias(MS2Manager.getSqlDialect().makeDatabaseIdentifier(name)); |
Contributor
Author
There was a problem hiding this comment.
Since names are mixed-case, we just have to make sure our usages are consistent. But it would be obvious if there were a problem.
labkey-jeckels
changed the title
labkey-jeckels
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fix MS2 tests
Related Pull Requests
Changes